fix(avc/slice): entire NALU consumed as slice header #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
thejoeejoee
commented
Sep 26, 2023
•
thejoeejoee
commented
- fix forloops in avc/slice header parser, where break doesn't break outer parser loop
thejoeejoee
changed the title
tobbee
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Hi @thejoeejoee,
thanks for your PR. It looks fine to me.
How did you find the problem? Did you run the code towards an asset or by just reading the code? If you have some relevant test material it would be great to add a small bit of it.
thejoeejoee
force-pushed
the
fix-avc-slice-header
branch
from
6161e63
to
34e3d0d
Compare
|
Exactly, I was doing some experiments with encryption and parsed |
thejoeejoee
force-pushed
the
fix-avc-slice-header
branch
from
34e3d0d
to
daab25c
Compare
thejoeejoee
force-pushed
the
fix-avc-slice-header
branch
from
daab25c
to
1ab0463
Compare
tobbee
approved these changes
Sep 27, 2023
tobbee
reviewed
Sep 27, 2023
avc/slice_test.go
Outdated
|
|
||
| func TestParseSliceHeader_TwoFrames(t *testing.T) { | ||
| wantedIdrHdr := SliceHeader{SliceType: SLICE_I, IDRPicID: 1, SliceQPDelta: 8, Size: 5} | ||
| wantedNonIdrHdr := SliceHeader{SliceType: SLICE_P, FrameNum: 1, ModificationOfPicNumsIDC: 3, SliceQPDelta: 13, Size: 5, NumRefIdxActiveOverrideFlag: true, RefPicListModificationL0Flag: true} |
There was a problem hiding this comment.
Hmm. This line is 194 characters long, so it exceeds the maximum line length of 140 configured in .golangci.yml.
Just break it.
There was a problem hiding this comment.
missed that, fixed
thejoeejoee
force-pushed
the
fix-avc-slice-header
branch
from
1ab0463
to
939329b
Compare
|
Great! Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.